chia7712 commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2061411092
##########
core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala:
##########
@@ -567,7 +568,7 @@ class SaslSslAdminIntegrationTest extends
BaseAdminIntegrationTest with SaslSetu
client.createAcls(List(denyAcl).asJava, new
CreateAclsOptions()).all().get()
val topics = Seq(topic1, topic2)
- val configsOverride = Map(TopicConfig.SEGMENT_BYTES_CONFIG ->
"100000").asJava
+ val configsOverride = Map(LogConfig.INTERNAL_SEGMENT_BYTES_CONFIG ->
"100000").asJava
Review Comment:
this test case is used to verify the custom topic-level config, so we can
increase the value to make test pass.
##########
raft/src/main/java/org/apache/kafka/raft/MetadataLogConfig.java:
##########
@@ -52,14 +51,14 @@ public class MetadataLogConfig {
"configuration. The Kafka node will generate a snapshot when
either the maximum time interval is reached or the " +
"maximum bytes limit is reached.";
- public static final String METADATA_LOG_SEGMENT_MIN_BYTES_CONFIG =
"metadata.log.segment.min.bytes";
- public static final String METADATA_LOG_SEGMENT_MIN_BYTES_DOC = "Override
the minimum size for a single metadata log file. This should be used for
testing only.";
- public static final int METADATA_LOG_SEGMENT_MIN_BYTES_DEFAULT = 8 * 1024
* 1024;
-
public static final String METADATA_LOG_SEGMENT_BYTES_CONFIG =
"metadata.log.segment.bytes";
public static final String METADATA_LOG_SEGMENT_BYTES_DOC = "The maximum
size of a single metadata log file.";
public static final int METADATA_LOG_SEGMENT_BYTES_DEFAULT = 1024 * 1024 *
1024;
+ public static final String INTERNAL_METADATA_LOG_SEGMENT_BYTES_CONFIG =
"internal.metadata.log.segment.bytes";
Review Comment:
Do we need another internal config? User can configure
`internal.segment.bytes` if they want to create small segment, right?
##########
core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala:
##########
@@ -601,7 +602,7 @@ class SaslSslAdminIntegrationTest extends
BaseAdminIntegrationTest with SaslSetu
assertNotEquals(Uuid.ZERO_UUID, createResult.topicId(topic1).get())
assertEquals(topicIds(topic1), createResult.topicId(topic1).get())
assertFutureThrows(classOf[TopicAuthorizationException],
createResult.topicId(topic2))
-
+
Review Comment:
please revert unrelated change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
