junrao commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2093536869
##########
core/src/test/scala/unit/kafka/log/LogConfigTest.scala:
##########
@@ -52,8 +52,13 @@ class LogConfigTest {
assertTrue(LogConfig.configNames.asScala
.filter(config =>
!LogConfig.CONFIGS_WITH_NO_SERVER_DEFAULTS.contains(config))
.forall { config =>
- val serverConfigOpt = LogConfig.serverConfigName(config)
- serverConfigOpt.isPresent && (serverConfigOpt.get != null)
+ // this internal config naming pattern is not as same as a default
pattern
+ if (config.equals(LogConfig.INTERNAL_SEGMENT_BYTES_CONFIG)) {
Review Comment:
Why do we need this? ALL_TOPIC_CONFIG_SYNONYMS includes
INTERNAL_SEGMENT_BYTES_CONFIG.
##########
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##########
@@ -50,6 +50,7 @@ public final class ServerTopicConfigSynonyms {
// Topic configs with no mapping to a server config can be found in
`LogConfig.CONFIGS_WITH_NO_SERVER_DEFAULTS`
public static final Map<String, List<ConfigSynonym>>
ALL_TOPIC_CONFIG_SYNONYMS = Utils.mkMap(
sameNameWithLogPrefix(TopicConfig.SEGMENT_BYTES_CONFIG),
+ sameName("internal.log." + TopicConfig.SEGMENT_BYTES_CONFIG),
Review Comment:
This is not really the same name. Could we add a method like
sameNameWithInternalLogPrefix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
