chia7712 commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2097986937
##########
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##########
@@ -47,9 +48,11 @@ public final class ServerTopicConfigSynonyms {
* both the first and the second synonyms are configured, we will use only
the value of
* the first synonym and ignore the second.
*/
- // Topic configs with no mapping to a server config can be found in
`LogConfig.CONFIGS_WITH_NO_SERVER_DEFAULTS`
public static final Map<String, List<ConfigSynonym>>
ALL_TOPIC_CONFIG_SYNONYMS = Utils.mkMap(
sameNameWithLogPrefix(TopicConfig.SEGMENT_BYTES_CONFIG),
+ // Due to the internal.segment.bytes is in storage module, thus we
could not use the
+ // LogConfig#INTERNAL_SEGMENT_BYTES_CONFIG directly. We need to use
the string value instead.
+ sameNameWithInternalLogPrefix("internal.segment.bytes"),
Review Comment:
@m1a2st
Do you mean this PR supports only topic-level internal config? If so, we
can't use small segment for Kraft topic as it takes only server-level config.
Do I understand correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
