PhillHenry commented on code in PR #3729:
URL: https://github.com/apache/polaris/pull/3729#discussion_r2855056483
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionConfigInfoDpo.java:
##########
@@ -117,7 +122,7 @@ public AuthenticationParametersDpo
getAuthenticationParameters() {
return serviceIdentity;
}
- private static final ObjectMapper DEFAULT_MAPPER;
+ @VisibleForTesting static final ObjectMapper DEFAULT_MAPPER;
Review Comment:
What I mean is if somebody changes the configuration of
ConnectionConfigInfoDpo.DEFAULT_MAPPER (eg, changing
`defaultPropertyInclusion`, `disable` etc) then test code that uses its own
ObjectMapper is no longer reliable.
But I see your point. I've adopted your idea of using
`ConnectionConfigInfoDpo.serialize()` at the small cost of wrapping my
`GcpAuthenticationParametersDpo` in a `IcebergRestConnectionConfigInfoDpo`.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
