dimas-b commented on code in PR #3729:
URL: https://github.com/apache/polaris/pull/3729#discussion_r2854318778
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionConfigInfoDpo.java:
##########
@@ -117,7 +122,7 @@ public AuthenticationParametersDpo
getAuthenticationParameters() {
return serviceIdentity;
}
- private static final ObjectMapper DEFAULT_MAPPER;
+ @VisibleForTesting static final ObjectMapper DEFAULT_MAPPER;
Review Comment:
TBH, if we use exactly the same mapper object to write and the read
`GcpAuthenticationParametersDpo` in a test, we're mostly testing Jackson rather
than Polaris code :thinking:
Why not use `ConnectionConfigInfoDpo.serialize()` and `deserialize()`
instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
