dimas-b commented on code in PR #3729:
URL: https://github.com/apache/polaris/pull/3729#discussion_r2854284270
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionConfigInfoDpo.java:
##########
@@ -117,7 +122,7 @@ public AuthenticationParametersDpo
getAuthenticationParameters() {
return serviceIdentity;
}
- private static final ObjectMapper DEFAULT_MAPPER;
+ @VisibleForTesting static final ObjectMapper DEFAULT_MAPPER;
Review Comment:
`polaris-core` has historically been a sensitive area in terms of changes to
the accessible class/method surface. Exposing a field is easy, hiding it again
can be problematic :sweat_smile:
Could you give a bit more details on the potential false positive test
issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
