PhillHenry commented on code in PR #3729: URL: https://github.com/apache/polaris/pull/3729#discussion_r2890451422
########## polaris-core/src/main/java/org/apache/polaris/core/connection/GcpAuthenticationParametersDpo.java: ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.core.connection; + +import com.fasterxml.jackson.annotation.JsonProperty; +import jakarta.annotation.Nonnull; +import java.util.HashMap; +import java.util.Map; +import java.util.Objects; +import org.apache.iceberg.CatalogProperties; +import org.apache.iceberg.rest.auth.AuthProperties; +import org.apache.polaris.core.admin.model.AuthenticationParameters; +import org.apache.polaris.core.admin.model.GcpAuthenticationParameters; +import org.apache.polaris.core.credentials.PolarisCredentialManager; + +/** + * See {@link org.apache.iceberg.rest.RESTUtil#configHeaders(Map)} and {@link + * org.apache.iceberg.rest.auth.AuthManagers#loadAuthManager(String, Map)} for why we do this. + */ +public class GcpAuthenticationParametersDpo extends AuthenticationParametersDpo { + private final String quotaProject; + private final String remoteWarehouseName; + + public GcpAuthenticationParametersDpo( + @JsonProperty(value = "quotaProject", required = true) @Nonnull String quotaProject, + @JsonProperty(value = "remoteWarehouseName", required = true) @Nonnull + String remoteWarehouseName) { + super(AuthenticationType.GCP.getCode()); + this.quotaProject = quotaProject; Review Comment: Hi @XJDKC I've done as you've suggested (to the best of my understanding) with the exception of adding GCP_CREDENTIALS_PATH_PROPERTY and GCP_SCOPES_PROPERTY to GcpAuthenticationParametersDpo as they would not be used in this ticket and I would recommend adding them in another ticket that uses them. Having said that, I don't feel strongly about this and am happy to add if you really want them in this ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
