MonkeyCanCode commented on code in PR #3759:
URL: https://github.com/apache/polaris/pull/3759#discussion_r2814876392
##########
.github/workflows/ci.yml:
##########
@@ -198,6 +198,16 @@ jobs:
version: 'v3.16.0'
- name: Set up chart-testing
uses:
helm/chart-testing-action@6ec842c01de15ebb84c8627d2744a0c2f2755c9f # v2.8.0
+ - name: Set up helm-docs
+ run: |
+ go install github.com/norwoodj/helm-docs/cmd/helm-docs@latest
+ echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
+ - name: Install Helm plugins
+ run: make helm-install-plugins
+ - name: Verify Helm schema is up to date
+ run: make helm-schema-verify
+ - name: Verify Helm documentation is up to date
Review Comment:
I see what you did here. Yes, this is valid as you have `helm-doc-generate`
as pre-task for this target thus if there are new changes, the git diff will
show non-zero exit status code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
