adutra commented on code in PR #3759: URL: https://github.com/apache/polaris/pull/3759#discussion_r2821626392
########## CHANGELOG.md: ########## @@ -32,6 +32,9 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti ### Upgrade notes - The custom token-bucket based rate limiter has been replaced with Guava's rate limiter implementation. +- The Helm chart now includes a JSON schema file for easy validation of values files. Because types + are now validated, existing values files may need to be updated to match the new schema. Review Comment: I commented on the ML already, but I think "breaking" in this case is up for debate, but I don't have strong opinions either. I will go ahead and merge this PR as is to speed up things a bit, but let me know if you think I should move this sentence under "Breaking changes". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
