adutra commented on PR #3759: URL: https://github.com/apache/polaris/pull/3759#issuecomment-3909056444
A few remarks about the change in this PR: Having the values.yaml file be the source of truth for _both_ documentation and schema generation is imho very valuable. For the schema generation to be successful, the values.yaml file must be fully "self-describing". In particular, commented-out sections won't work well (they will generate a generic object or array schema). Two parts of our Helm chart were affected: the `extraServices` section and the `ingress.tls` section. Instead of being commented out, they now appear in full. The trick is to consider some property as a sentinel for triggering generation of corresponding Kubernetes objects. In the case of `extraServices`, the "sentinel" is the `nameSuffix` field: if it's empty (the default value) the array element is ignored and no service is generated. In the case of `ingress.tls`, the array element is only generated if _both_ `ingress.tls[].secretName` and `ingress.tls[].hosts` are non-empty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
