adutra commented on code in PR #3759: URL: https://github.com/apache/polaris/pull/3759#discussion_r2812668134
########## Makefile: ########## @@ -215,16 +215,62 @@ client-cleanup: ## Cleanup virtual environment and Python cache files ##@ Helm +helm-install-plugins: DEPENDENCIES := helm +.PHONY: helm-install-plugins +helm-install-plugins: check-dependencies ## Install required Helm plugins (unittest, schema) + @echo "--- Installing Helm plugins ---" + # Pin unittest version to 1.0.2 due to https://github.com/helm-unittest/helm-unittest/issues/790 + @if helm plugin list | grep -q "^unittest"; then \ Review Comment: I have Helm 4 installed and I observed two things: 1. It's not necessary anymore to pin the helm-unit version (it works with Helm 3.18+) 2. Both plugins need `--verify=false` with Helm 4 I modified the target accordingly and removed all the version pinnings. Let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
