eric-maynard commented on code in PR #2422:
URL: https://github.com/apache/polaris/pull/2422#discussion_r2299325296
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -100,6 +100,16 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
+ public static final FeatureConfiguration<Boolean>
ALLOW_NAMESPACE_LOCATION_ESCAPE =
+ PolarisConfiguration.<Boolean>builder()
+ .key("ALLOW_NAMESPACE_LOCATION_ESCAPE")
Review Comment:
In this case I think we want to have a flag for parity with tables -- the
"bug" here IMO is that the default behavior is too lax, not that the lax
behavior is accessible at all.
I'll create a quick thread to discuss the change in more detail, but in
general it's not healthy for a project to require ML discussion for every new
config. This creates an incentive to not protect changes with configs, and in
the ideal world where all changes are config-protected this essentially
necessitates an ML thread for every PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
