eric-maynard commented on code in PR #2422:
URL: https://github.com/apache/polaris/pull/2422#discussion_r2301787032


##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -508,6 +508,11 @@ private void createNamespaceInternal(
     } else {
       LOGGER.debug("Skipping location overlap validation for namespace '{}'", 
namespace);
     }
+    if (!realmConfig.getConfig(
+        FeatureConfiguration.ALLOW_NAMESPACE_CUSTOM_LOCATION, catalogEntity)) {

Review Comment:
   @flyrain the current behavior is (1), so the flag protects the behavior 
change and lets you revert to the current behavior. An earlier version of the 
PR did implement (2).
   
   This new behavior intended to behave exactly like 
`ALLOW_EXTERNAL_TABLE_LOCATION` for the sake of parity. I shied away from using 
"external" in the name because it's now a bit of a loaded term within Polaris.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to