flyrain commented on code in PR #2422:
URL: https://github.com/apache/polaris/pull/2422#discussion_r2301550256
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -508,6 +508,11 @@ private void createNamespaceInternal(
} else {
LOGGER.debug("Skipping location overlap validation for namespace '{}'",
namespace);
}
+ if (!realmConfig.getConfig(
+ FeatureConfiguration.ALLOW_NAMESPACE_CUSTOM_LOCATION, catalogEntity)) {
Review Comment:
I think we are thinking about two different types of custom location
1. Free form, the locations could be in anywhere. I believe this configure
is for that. Do we have a use case for this? I feel this is a wild behavior,
there is no guarantee that credential vending or other location related things
will work.
2. still in the parent directory, but users can give a different sub
prefix/dir name other than the default one, `parent/namespace_name`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
