eric-maynard commented on code in PR #2422:
URL: https://github.com/apache/polaris/pull/2422#discussion_r2294348780
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -100,6 +100,16 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
+ public static final FeatureConfiguration<Boolean>
ALLOW_NAMESPACE_LOCATION_ESCAPE =
+ PolarisConfiguration.<Boolean>builder()
+ .key("ALLOW_NAMESPACE_LOCATION_ESCAPE")
Review Comment:
Is that so? That seems to create a weird incentive not to feature-flag
anything.
In this particular case there's a behavior change due to the default setting
of the flag so in that sense it's relevant to semver, but it's also a bugfix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
