eric-maynard commented on code in PR #2105:
URL: https://github.com/apache/polaris/pull/2105#discussion_r2211037515
##########
service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java:
##########
@@ -58,4 +58,14 @@ FileIO loadFileIO(
@Nonnull Set<String> tableLocations,
@Nonnull Set<PolarisStorageActions> storageActions,
@Nonnull PolarisResolvedPathWrapper resolvedEntityPath);
+
+ static FileIOFactory wrapExisting(FileIO fileIO) {
Review Comment:
It's up to you, I personally still think the cleanup is a good idea as it
should make it easier to write new tests. I'm more concerned about lowering the
cognitive load needed to set up a new test than about lowering LOC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
