eric-maynard commented on code in PR #2105:
URL: https://github.com/apache/polaris/pull/2105#discussion_r2208094573
##########
service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java:
##########
@@ -58,4 +58,14 @@ FileIO loadFileIO(
@Nonnull Set<String> tableLocations,
@Nonnull Set<PolarisStorageActions> storageActions,
@Nonnull PolarisResolvedPathWrapper resolvedEntityPath);
+
+ static FileIOFactory wrapExisting(FileIO fileIO) {
Review Comment:
I would recommend the `org.apache.polaris.service` package in `testFixtures`
alongside `TestServices`.
The reason that I am a bit unsure about putting it outside of test code is
that we did in fact design FileIOFactory with a sort of a sort of "wrapper"
pattern in mind (WasbTranslatingFileIOFactory` for an example) and I worry that
having introducing a method like will have implications on that pattern or on
how maintainers perceive that pattern is meant to be implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
