XN137 commented on code in PR #2105:
URL: https://github.com/apache/polaris/pull/2105#discussion_r2211017517
##########
service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java:
##########
@@ -58,4 +58,14 @@ FileIO loadFileIO(
@Nonnull Set<String> tableLocations,
@Nonnull Set<PolarisStorageActions> storageActions,
@Nonnull PolarisResolvedPathWrapper resolvedEntityPath);
+
+ static FileIOFactory wrapExisting(FileIO fileIO) {
Review Comment:
> I worry that having introducing a method like will have implications on
that pattern or on how maintainers perceive that pattern is meant to be
implemented
my point was that since the method is static this worry is unjustified, the
"pattern" is not affected at all by the static method in the interface.
that being said, i have now done as you had requested.
however taking a look at it now, not sure if the cleanup is really worth it
as it adds a new class that isnt that easy to discover and its no longer a
clear win in terms of lines of code, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
