XN137 commented on code in PR #2105:
URL: https://github.com/apache/polaris/pull/2105#discussion_r2208054618
##########
service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java:
##########
@@ -58,4 +58,14 @@ FileIO loadFileIO(
@Nonnull Set<String> tableLocations,
@Nonnull Set<PolarisStorageActions> storageActions,
@Nonnull PolarisResolvedPathWrapper resolvedEntityPath);
+
+ static FileIOFactory wrapExisting(FileIO fileIO) {
Review Comment:
i would argue this is shorter and more discoverable, also while its true
that its only used from tests right now, the logic is still generally correct
outside of tests.
if you insist, i can still move it to new `TestFileIOFactory` (any specific
module/package) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
