dimas-b commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2205680574
##########
spec/polaris-management-service.yml:
##########
@@ -1056,6 +1056,12 @@ components:
type: string
description: endpoint for STS requests (optional). If not set,
defaults to 'endpoint'.
example: "https://sts.example.com:1234";
+ pathStyleAccess:
+ type: boolean
+ description: >-
+ Whether S3 requests to files in this catalog should use
'path-style addressing for buckets'.
+ Default: false.
Review Comment:
@eric-maynard : the new test shows AWS config data roundtrips via API with
and without (defaults) values for the new properties.
If the new properties are not set, clients will not see them in JSON outputs
of the REST API endpoints. So, this change does not break existing
installations and old clients as long as Polaris users do not use the new
properties. If users do reconfigure catalogs to use the new properties, it's
the user's responsibility to also update clients to be compatible with the
catalog JSON configuration (e.g. use new CLI).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
