eric-maynard commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2196446395
##########
spec/polaris-management-service.yml:
##########
@@ -1056,6 +1056,12 @@ components:
type: string
description: endpoint for STS requests (optional). If not set,
defaults to 'endpoint'.
example: "https://sts.example.com:1234";
+ pathStyleAccess:
+ type: boolean
+ description: >-
+ Whether S3 requests to files in this catalog should use
'path-style addressing for buckets'.
+ Default: false.
Review Comment:
> However, this is under the user / operator control.
Is it? If I'm reading your PR correctly once I create a new
StorageConfigInfo, it will have a value of `false` written into it for
`pathStyleAccess`... and that will be returned to all clients. There's no way
for me to control that besides just not making any new catalogs. At least,
that's what "Default: false" in the description from the spec seems to imply.
If you consider that a breaking change, then this PR is already a breaking
change and in that case I think we should just use a default in the API.
If you do not consider that a breaking change, then it's also not a breaking
change to use a default in the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
