eric-maynard commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2208304995
##########
spec/polaris-management-service.yml:
##########
@@ -1056,6 +1056,12 @@ components:
type: string
description: endpoint for STS requests (optional). If not set,
defaults to 'endpoint'.
example: "https://sts.example.com:1234";
+ pathStyleAccess:
+ type: boolean
+ description: >-
+ Whether S3 requests to files in this catalog should use
'path-style addressing for buckets'.
+ Default: false.
Review Comment:
> do you prefer adding default in the Open API spec
Yes, if the field has a default I think that should be governed by the spec.
> this has some risk of breaking existing clients (as explained above)?
The _marginal_ risk increase of adding a default seems small. Besides the
fact that the appearance of a new field isn't a breaking change as @snazy and I
argue above, the new field also appears if you create new a catalog using the
PR as-is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
