poojanilangekar commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2183861940
##########
runtime/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisAdminServiceAuthzTest.java:
##########
@@ -151,7 +152,8 @@ public void testCreateCatalogSufficientPrivileges() {
@Test
public void testCreateCatalogInsufficientPrivileges() {
- final CatalogEntity newCatalog = new
CatalogEntity.Builder().setName("new_catalog").build();
+ final CatalogEntity newCatalog =
+ new
CatalogEntity.Builder().setName("new_catalog").setCatalogType("INTERNAL").build();
Review Comment:
I think the fix is simple, I can create a separate PR to fix it.
https://github.com/apache/polaris/blob/9cb71f8125d79e9bb16117c9110211394173b821/polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java#L109
The builder checks if the `catalogType` is `INTERNAL`, if not, it assumes
that the type is `EXTERNAL`, we can flip the condition to check if the type is
set to `EXTEERNAL`. I also think that the change only affects tests, because
in other cases, it's generated from polaris-management-service.yml which
defaults to `INTERNAL`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
