flyrain commented on code in PR #1830:
URL: https://github.com/apache/polaris/pull/1830#discussion_r2133969406


##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -151,13 +151,16 @@ tasks.register("checkNoDisallowedImports") {
 tasks.named("check") { dependsOn("checkNoDisallowedImports") }
 
 tasks.register<ShadowJar>("createPolarisSparkJar") {
-  archiveClassifier = null
-  archiveBaseName =
-    
"polaris-iceberg-${icebergVersion}-spark-runtime-${sparkMajorVersion}_${scalaVersion}"
+  archiveClassifier = "bundle"

Review Comment:
   >  it seems wired that the iceberg version is after the polaris version.
   
   True. The only option is to play with the project name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to