gh-yzou commented on code in PR #1830:
URL: https://github.com/apache/polaris/pull/1830#discussion_r2136114240
##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -151,13 +151,16 @@ tasks.register("checkNoDisallowedImports") {
tasks.named("check") { dependsOn("checkNoDisallowedImports") }
tasks.register<ShadowJar>("createPolarisSparkJar") {
- archiveClassifier = null
- archiveBaseName =
-
"polaris-iceberg-${icebergVersion}-spark-runtime-${sparkMajorVersion}_${scalaVersion}"
+ archiveClassifier = "bundle"
Review Comment:
```
I don't think we need to do that.
```
Sorry, i meant every time we update the iceberg dependency version in
Polaris, for example, when polaris is updated from 1.7 -> 1.8 -> 1.9, i don't
mean every time when there is new iceberg version available.
Actually, after some thought, i don't think we should include the iceberg
version in the package name. The polaris client is a client we provided for
spark to communicate with polaris, the spark scala version is used to tell the
spark scala compatibility when choosing which library to use. For the iceberg,
even though we ship an iceberg runtime along with our package today, we don't
really guarantee any compatibility with the iceberg client, in other words,
user can not use an iceberg runtime jar with the polaris jar we provided. The
iceberg client is more like a dependency we ship with, which i think makes more
sense to be doc correctly, instead of add it in the package name, which
actually could be confusing to users in other aspects also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
