flyrain commented on code in PR #1830:
URL: https://github.com/apache/polaris/pull/1830#discussion_r2133360397
##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -151,13 +151,16 @@ tasks.register("checkNoDisallowedImports") {
tasks.named("check") { dependsOn("checkNoDisallowedImports") }
tasks.register<ShadowJar>("createPolarisSparkJar") {
- archiveClassifier = null
- archiveBaseName =
-
"polaris-iceberg-${icebergVersion}-spark-runtime-${sparkMajorVersion}_${scalaVersion}"
+ archiveClassifier = "bundle"
Review Comment:
Think a bit more, I think it'd be nice to have the iceberg version in the
package name. Otherwise, debugging would be tricky. Users couldn't figure out
the Iceberg lib version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
