gh-yzou commented on code in PR #1830:
URL: https://github.com/apache/polaris/pull/1830#discussion_r2133441707
##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -151,13 +151,16 @@ tasks.register("checkNoDisallowedImports") {
tasks.named("check") { dependsOn("checkNoDisallowedImports") }
tasks.register<ShadowJar>("createPolarisSparkJar") {
- archiveClassifier = null
- archiveBaseName =
-
"polaris-iceberg-${icebergVersion}-spark-runtime-${sparkMajorVersion}_${scalaVersion}"
+ archiveClassifier = "bundle"
Review Comment:
The name of the jar now seems
<project_name>-<polaris_version>-<classifier>.jar, and the scala_version is
embedded in the project_name, such as spark-3.5_2.12. I don't think it is a
good idea to have iceberg version as project name, since the iceberg version
might gets updated more frequently.
i don't think we can touch polaris_version also, then classifier is the only
place . however, it seems wired that the iceberg version is after the polaris
version. I think what we can do is publish on the webpage about the iceberg
client compatibility. Given in long term, we may not need iceberg version in
the package name also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
