sfc-gh-emaynard commented on code in PR #1426:
URL: https://github.com/apache/polaris/pull/1426#discussion_r2057102547
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1203,6 +1215,77 @@ private class BasePolarisTableOperations extends
BaseMetastoreTableOperations {
}
@Override
+ public TableMetadata current() {
+ if (shouldRefresh) {
+ return refresh();
+ }
+ return currentMetadata;
+ }
+
+ @Override
+ public TableMetadata refresh() {
Review Comment:
I would love to move to a top-level class, however these classes are very
tightly coupled with `IcebergCatalog` right now and they use many of its member
variables (and IIRC, methods). The refactor gets significantly more complicated
if I try to do that. So, I thought to make this smaller more incremental change
which is what's needed to actually unblock the behavior proposed on #1378.
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1203,6 +1215,77 @@ private class BasePolarisTableOperations extends
BaseMetastoreTableOperations {
}
@Override
+ public TableMetadata current() {
+ if (shouldRefresh) {
+ return refresh();
+ }
+ return currentMetadata;
+ }
+
+ @Override
+ public TableMetadata refresh() {
Review Comment:
I would love to move to a top-level class, however these classes are very
tightly coupled with `IcebergCatalog` right now and they use many of its member
variables (and IIRC, methods). The refactor gets significantly more complicated
if I try to do that. So, I thought to make this smaller more incremental change
which is what's needed to actually unblock the behavior proposed on #1378.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
