eric-maynard commented on code in PR #1426:
URL: https://github.com/apache/polaris/pull/1426#discussion_r2057062046
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1203,6 +1215,77 @@ private class BasePolarisTableOperations extends
BaseMetastoreTableOperations {
}
@Override
+ public TableMetadata current() {
+ if (shouldRefresh) {
+ return refresh();
+ }
+ return currentMetadata;
+ }
+
+ @Override
+ public TableMetadata refresh() {
Review Comment:
edit: to be clear there should be no functional changes, but there are minor
changes (e.g. LOG -> LOGGER) needed to make things work within IcebergCatalog
and I have done some light refactoring to improve readability and reduce
repeated code. In the future though we may make functional changes. I've added
a comment at least calling out that the code was originally more or less copied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
