eric-maynard commented on code in PR #1426:
URL: https://github.com/apache/polaris/pull/1426#discussion_r2057049764
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1203,6 +1215,77 @@ private class BasePolarisTableOperations extends
BaseMetastoreTableOperations {
}
@Override
+ public TableMetadata current() {
+ if (shouldRefresh) {
+ return refresh();
+ }
+ return currentMetadata;
+ }
+
+ @Override
+ public TableMetadata refresh() {
Review Comment:
I agree that we should communicate that most of this was copied, good
callout.
However, currently AFAIK `CODE_COPIED_TO_POLARIS` is reserved for blocks of
code (files) that are 100% copied with no modifications. There are some
modifications here, and we are planning to make more over time. What do you
think is the best way to represent the situation -- should we just put
`CODE_COPIED_TO_POLARIS` and explain this in a comment?
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1203,6 +1215,77 @@ private class BasePolarisTableOperations extends
BaseMetastoreTableOperations {
}
@Override
+ public TableMetadata current() {
+ if (shouldRefresh) {
+ return refresh();
+ }
+ return currentMetadata;
+ }
+
+ @Override
+ public TableMetadata refresh() {
Review Comment:
I agree that we should communicate that most of this was copied, good
callout.
However, currently AFAIK `CODE_COPIED_TO_POLARIS` is reserved for blocks of
code (files?) that are 100% copied with no modifications. There are some
modifications here, and we are planning to make more over time. What do you
think is the best way to represent the situation -- should we just put
`CODE_COPIED_TO_POLARIS` and explain this in a comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
