dimas-b commented on code in PR #1426:
URL: https://github.com/apache/polaris/pull/1426#discussion_r2057093688
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1203,6 +1215,77 @@ private class BasePolarisTableOperations extends
BaseMetastoreTableOperations {
}
@Override
+ public TableMetadata current() {
+ if (shouldRefresh) {
+ return refresh();
+ }
+ return currentMetadata;
+ }
+
+ @Override
+ public TableMetadata refresh() {
Review Comment:
The idea for `CODE_COPIED_TO_POLARIS` is to automatically check
acknowledgement in LICENSE / NOTICE files. So technically any reuse of
substantial code blocks should be mentioned even if the code was modified.
@jbonofre : WDYT?
Since the check is by file name, one comment per file is sufficient. For
that matter, maybe it is best to move the reused code to a top-level class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
