RichardLiu2001 commented on code in PR #1431:
URL: https://github.com/apache/polaris/pull/1431#discussion_r2056860663
##########
server-templates/api.mustache:
##########
@@ -108,6 +110,7 @@ public class {{classname}} {
@Produces({ {{#produces}}"{{{mediaType}}}"{{^-last}},
{{/-last}}{{/produces}} }){{/hasProduces}}{{#hasAuthMethods}}
{{#authMethods}}{{#isOAuth}}@RolesAllowed("**"){{/isOAuth}}{{/authMethods}}{{/hasAuthMethods}}
@Timed("{{metricsPrefix}}.{{baseName}}.{{nickname}}")
+ @Timeout
Review Comment:
>How is the timeout actually defined?
Quarkus configs - I added a default value of 60s to the default
`application.properties`.
>will it actually cancel the server-side processing?
The API method will throw a `TimeoutException` which gets appropriately
mapped in the `IcebergExceptionMapper`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
