RichardLiu2001 commented on code in PR #1431:
URL: https://github.com/apache/polaris/pull/1431#discussion_r2056858558
##########
api/iceberg-service/build.gradle.kts:
##########
@@ -45,6 +45,9 @@ dependencies {
implementation("com.fasterxml.jackson.core:jackson-annotations")
implementation("com.fasterxml.jackson.core:jackson-core")
implementation("com.fasterxml.jackson.core:jackson-databind")
+
+ compileOnly(platform(libs.quarkus.bom))
+ compileOnly("io.quarkus:quarkus-smallrye-fault-tolerance")
Review Comment:
>Why do we need this dep?
This dep is so that `IcebergRestCatalogApi` can compile.
> believe this control should be applied to implementations, not to API
definitions
Why? Is it to avoid adding a Quarkus dependency in the API? If so, what is
wrong with that?
We also have `@Timed` at the API level. Why is that acceptable but
`@Timeout` isn't?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
