eric-maynard commented on code in PR #1431:
URL: https://github.com/apache/polaris/pull/1431#discussion_r2056802062
##########
server-templates/api.mustache:
##########
@@ -108,6 +110,7 @@ public class {{classname}} {
@Produces({ {{#produces}}"{{{mediaType}}}"{{^-last}},
{{/-last}}{{/produces}} }){{/hasProduces}}{{#hasAuthMethods}}
{{#authMethods}}{{#isOAuth}}@RolesAllowed("**"){{/isOAuth}}{{/authMethods}}{{/hasAuthMethods}}
@Timed("{{metricsPrefix}}.{{baseName}}.{{nickname}}")
+ @Timeout
Review Comment:
Within Open Catalog, server-side timeouts have been very useful for
protecting the service from very long-running requests. Clients can of course
have their own timeouts, but I think server side timeouts are very beneficial.
Agreed that this only makes sense if the server-side processing actually
gets cancelled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
