dimas-b commented on code in PR #1431:
URL: https://github.com/apache/polaris/pull/1431#discussion_r2057072793
##########
server-templates/api.mustache:
##########
@@ -108,6 +110,7 @@ public class {{classname}} {
@Produces({ {{#produces}}"{{{mediaType}}}"{{^-last}},
{{/-last}}{{/produces}} }){{/hasProduces}}{{#hasAuthMethods}}
{{#authMethods}}{{#isOAuth}}@RolesAllowed("**"){{/isOAuth}}{{/authMethods}}{{/hasAuthMethods}}
@Timed("{{metricsPrefix}}.{{baseName}}.{{nickname}}")
+ @Timeout
Review Comment:
After reading the docs :) I guess the server thread will get a simple java
interrupt, which does look useful. Sorry, I should have paid more attention to
this PR initially :facepalm:
It LGTM (assuming longer default timeput), but let's collect some more
reviews, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
