martinzink commented on code in PR #2148:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2148#discussion_r3015004695
##########
libminifi/src/sitetosite/CompressionOutputStream.cpp:
##########
@@ -103,7 +103,7 @@ size_t CompressionOutputStream::compressAndWrite() {
}
// Write the compressed data
- ret = internal::pipe(buffer_stream, internal_stream_);
+ ret = minifi::io::IoResult(internal::pipe(buffer_stream,
internal_stream_)).toI64(); // TODO(mzink) feels wrong
Review Comment:
[review
changes](https://github.com/apache/nifi-minifi-cpp/pull/2148/commits/35e35c3c938e866668a9ab1545218fa3d40f6ea8)
yeah that makes sense, its still strange that we only return the last
operations size and not totalling it, but I probably dont want to poke this
anymore in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
