Copilot commented on code in PR #2148: URL: https://github.com/apache/nifi-minifi-cpp/pull/2148#discussion_r3008069696
########## minifi-api/common/include/minifi-cpp/io/StreamCallback.h: ########## @@ -16,24 +16,101 @@ */ #pragma once +#include <cinttypes> #include <functional> #include <memory> #include <optional> +#include "../../minifi-api/include/minifi-c/minifi-c.h" +#include "Stream.h" +#include "minifi-cpp/utils/gsl.h" +#include "utils/expected.h" Review Comment: The `#include "../../minifi-api/include/minifi-c/minifi-c.h"` path appears incorrect relative to this header's location (it resolves under `minifi-api/common/include/...`, which doesn't contain `minifi-api/include/...`). This is likely to break compilation. Prefer including the header via an include-dir-relative path such as `minifi-c/minifi-c.h` (or otherwise adjust to the correct relative path to `minifi-api/include/minifi-c/minifi-c.h`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
