fgerlits commented on code in PR #2148:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2148#discussion_r3014320603
##########
libminifi/src/sitetosite/CompressionOutputStream.cpp:
##########
@@ -103,7 +103,7 @@ size_t CompressionOutputStream::compressAndWrite() {
}
// Write the compressed data
- ret = internal::pipe(buffer_stream, internal_stream_);
+ ret = minifi::io::IoResult(internal::pipe(buffer_stream,
internal_stream_)).toI64(); // TODO(mzink) feels wrong
Review Comment:
Yes, but the return value at the end should be
`gsl::narrow<size_t>(pipe_res.toI64())` or something similar, not `ret`.
In fact, it would be nice to get rid of the reusing of `ret` in this
function, and use separate variables each time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
