martinzink commented on code in PR #2148: URL: https://github.com/apache/nifi-minifi-cpp/pull/2148#discussion_r3013606737
########## minifi-api/common/include/minifi-cpp/io/StreamCallback.h: ########## @@ -16,24 +16,101 @@ */ #pragma once +#include <cinttypes> #include <functional> #include <memory> #include <optional> +#include "../../minifi-api/include/minifi-c/minifi-c.h" Review Comment: unfortunetly it wont work, this is included from files where the search path only includes minifi-api/include/minifi-c so you need `#include "minifi-c.h"` (e.g. extension-framework/cpp-extension-lib/src/core/ProcessSession.cpp) and also from files where the search path only includes minifi-api/include so you would need `#include "minifi-c/minifi-c.h"` (e.g. core-framework/src/core/ContentSession.cpp) We should probably fix this but didnt want to burden this PR (and more so myself) with the cmake magic that controls these -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
