Pankraz76 commented on code in PR #2277:
URL: https://github.com/apache/maven/pull/2277#discussion_r2105350817
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultJavaToolchainFactory.java:
##########
@@ -109,30 +110,35 @@ static class DefaultJavaToolchain implements
JavaToolchain {
}
@Override
+ @Nonnull
public String getJavaHome() {
return javaHome;
}
@Override
+ @Nonnull
public String getType() {
return "jdk";
}
@Override
+ @Nonnull
public ToolchainModel getModel() {
Review Comment:
but here not. how can this be null please?
<img width="1810" alt="image"
src="https://github.com/user-attachments/assets/6525474e-591f-447c-a362-688f327aa920";
/>
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultJavaToolchainFactory.java:
##########
@@ -109,30 +110,35 @@ static class DefaultJavaToolchain implements
JavaToolchain {
}
@Override
+ @Nonnull
public String getJavaHome() {
return javaHome;
}
@Override
+ @Nonnull
public String getType() {
return "jdk";
}
@Override
+ @Nonnull
public ToolchainModel getModel() {
Review Comment:
https://github.com/apache/maven/pull/2386
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultJavaToolchainFactory.java:
##########
@@ -109,30 +110,35 @@ static class DefaultJavaToolchain implements
JavaToolchain {
}
@Override
+ @Nonnull
public String getJavaHome() {
return javaHome;
}
@Override
+ @Nonnull
public String getType() {
return "jdk";
}
@Override
+ @Nonnull
public ToolchainModel getModel() {
Review Comment:
- https://github.com/apache/maven/pull/2386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
