Pankraz76 commented on code in PR #2277:
URL: https://github.com/apache/maven/pull/2277#discussion_r2071987522
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/AbstractSession.java:
##########
@@ -134,7 +132,7 @@ public AbstractSession(
List<RemoteRepository> repositories,
List<org.eclipse.aether.repository.RemoteRepository>
resolverRepositories,
Lookup lookup) {
- this.session = nonNull(session, "session");
Review Comment:
yes not ideal but its kind of clear it context of `NullPointerException`
whats going on. I would keep it, remove all, or at least separate the concerns
moving the "cannot be null" suffix into dedicated layer, avoiding DRY and
feature envy here, as fluff and c&p.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
