Pankraz76 commented on PR #2277:
URL: https://github.com/apache/maven/pull/2277#issuecomment-2850710999

   Yes we working on a dedicated commit for each concern. Thanks Sent from my 
iPhoneOn 5 May 2025, at 12:41, Elliotte Rusty Harold ***@***.***> wrote:
   @elharo requested changes on this pull request.
   
   "Use modern Java collections API (toList() instead of 
collect(Collectors.toList()))" is riskier than the other changes because of the 
move of mutable to immutable lists. Nine times out of ten this is fine. The 
tenth time it's a bear to debug. These changes should be pulled out into a 
separate PR.
   The rest could be split, but maybe don't have to be. Nuulable and Nonnull 
might also call for a separate PR.
   
   —Reply to this email directly, view it on GitHub, or unsubscribe.You are 
receiving this because you were mentioned.Message ID: ***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to