gnodet commented on code in PR #2042:
URL: https://github.com/apache/maven/pull/2042#discussion_r1919845361
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/MavenSimpleConfiguration.java:
##########
@@ -37,7 +41,14 @@ public void setRootLoggerLevel(Level level) {
case INFO -> "info";
default -> "error";
};
- System.setProperty("org.slf4j.simpleLogger.defaultLogLevel", value);
+
+ String current =
System.getProperty(MavenSimpleLogger.DEFAULT_LOG_LEVEL_KEY);
Review Comment:
```suggestion
String current =
System.setProperty(MavenSimpleLogger.DEFAULT_LOG_LEVEL_KEY, value);
if (current != null && !Objects.equals(value, current)) {
LOGGER.info("System property '" +
MavenSimpleLogger.DEFAULT_LOG_LEVEL_KEY + "' is already set to '"
+ current + "' - ignoring log level from -X/-e/-q
options");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
