gnodet commented on code in PR #2042:
URL: https://github.com/apache/maven/pull/2042#discussion_r1916028577
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/logging/impl/MavenSimpleConfiguration.java:
##########
@@ -37,7 +40,16 @@ public void setRootLoggerLevel(Level level) {
case INFO -> "info";
default -> "error";
};
- System.setProperty("org.slf4j.simpleLogger.defaultLogLevel", value);
+
+ String defaultLogLevelKey = "org.slf4j.simpleLogger.defaultLogLevel";
+ String current = System.getProperty(defaultLogLevelKey);
+ if (current == null) {
+ System.setProperty(defaultLogLevelKey, value);
+ } else {
Review Comment:
Actually, I'm not sure we want user properties to take precedence over CLI
options.
We use the same behavior for color for example:
https://github.com/apache/maven/blob/bebc3d4a2e987e59aa0666f71cf3b8688dde6f7a/impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java#L209-L212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
