elharo commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1876862759


##########
maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/MapVersionsPhaseTest.java:
##########
@@ -2452,6 +2453,9 @@ private static MavenProject createProject(String 
artifactId, String version) {
         model.setGroupId("groupId");
         model.setArtifactId(artifactId);
         model.setVersion(version);
-        return new MavenProject(model);
+
+        MavenProject mavenProject = new MavenProject(model);

Review Comment:
   does this actually test the bug? It looks like a little new setup code but I 
don't see how the behavior has changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to