elharo commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1883813971
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractScmCommitPhase.java:
##########
@@ -288,11 +303,25 @@ protected static List<File>
createPomFiles(ReleaseDescriptor releaseDescriptor,
* @param reactorProjects a {@link java.util.List} object
* @return a {@link java.util.List} object
*/
- protected static List<File> createPomFiles(
- ReleaseDescriptor releaseDescriptor, List<MavenProject>
reactorProjects) {
+ protected List<File> createPomFiles(ReleaseDescriptor releaseDescriptor,
List<MavenProject> reactorProjects) {
+
List<File> pomFiles = new ArrayList<>();
for (MavenProject project : reactorProjects) {
- pomFiles.addAll(createPomFiles(releaseDescriptor, project));
+
+ final String path = project.getFile().getPath();
Review Comment:
Might want to use a lambda and anyMatch here. Up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
