[ 
https://issues.apache.org/jira/browse/MPLUGIN-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844197#comment-17844197
 ] 

ASF GitHub Bot commented on MPLUGIN-522:
----------------------------------------

cstamas commented on PR #282:
URL: 
https://github.com/apache/maven-plugin-tools/pull/282#issuecomment-2097716799

   Ok, then we have similar situation as with prefix: fail the build.
   
   Plugin should be modified to:
   * if none set, fail the build
   * if "auto", as now
   * if value set, use that
   
   We must make users aware of this requirement (hence the build failure), as 
otherwise they implicitly use "auto" and end result is wrong.




> The auto prerequisites are way to aggressive
> --------------------------------------------
>
>                 Key: MPLUGIN-522
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-522
>             Project: Maven Plugin Tools
>          Issue Type: Bug
>          Components: Plugin Plugin
>            Reporter: Tamas Cservenak
>            Priority: Major
>
> IMHO the implementation done in MPLUGIN-425 and MPLUGIN-424 are wrong.
> They are way too aggresive and violate backward compatibility: if new feature 
> is not explicitly set by user, code should not "come up" with some automatic 
> value. By having the value not set simply means user does not want to use it.
> This is especially true for (maven or java) prerequisite, as it creates HARD 
> BREAKAGE if not met. Use of prerequisite is opt-in, but now it is FORCED onto 
> user.
> [~kwin] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to