[ 
https://issues.apache.org/jira/browse/MPLUGIN-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844220#comment-17844220
 ] 

ASF GitHub Bot commented on MPLUGIN-522:
----------------------------------------

cstamas commented on PR #282:
URL: 
https://github.com/apache/maven-plugin-tools/pull/282#issuecomment-2097838429

   This PR should be redone once Maven3 and Maven4 m-p-p are split (into 
maven-3.x and master) branch. And then:
   * default Java prerequisite should pick up from compiler plugin (in pretty 
much similar way as report does)
   * default Maven prerequisite should be "3.2.5" on maven-3.x branch and 
"4.0.0" on master branch.
   
   Originally, the lack of prerequisite meant "it works with Maven3" (no range 
specified). IMO, using "3.2.5" today is completely okay, it covers 10 years of 
history. If users wants to go more backward, it can explicitly configure 
prerequisite to "3.1.1" or whatever.




> The auto prerequisites are way to aggressive
> --------------------------------------------
>
>                 Key: MPLUGIN-522
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-522
>             Project: Maven Plugin Tools
>          Issue Type: Bug
>          Components: Plugin Plugin
>            Reporter: Tamas Cservenak
>            Priority: Major
>
> IMHO the implementation done in MPLUGIN-425 and MPLUGIN-424 are wrong.
> They are way too aggresive and violate backward compatibility: if new feature 
> is not explicitly set by user, code should not "come up" with some automatic 
> value. By having the value not set simply means user does not want to use it.
> This is especially true for (maven or java) prerequisite, as it creates HARD 
> BREAKAGE if not met. Use of prerequisite is opt-in, but now it is FORCED onto 
> user.
> [~kwin] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to