[ 
https://issues.apache.org/jira/browse/MPLUGIN-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843886#comment-17843886
 ] 

Tamas Cservenak commented on MPLUGIN-522:
-----------------------------------------

IMHO, any prerequisite should be added ONLY if explicitly specified. The two 
issues altered (in a wrong way) behaviour of m-p-p: they are ALWAYS added, and 
worse, the "auto" values are magically (and completely wrongly) calculated: if 
I _compile_ against 3.9.6 Maven APIs, that – due backward compatibility – does 
NOT mean plugin "has a prerequisite of 3.9.6". As we all know, they are happily 
working even with 3.6.3 or even 3.2.x.

Similarly, if I have one class that is Java 22, the plugin prerequisite is NOT 
Java 22.

> The auto prerequisites are way to aggressive
> --------------------------------------------
>
>                 Key: MPLUGIN-522
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-522
>             Project: Maven Plugin Tools
>          Issue Type: Bug
>          Components: Plugin Plugin
>            Reporter: Tamas Cservenak
>            Priority: Major
>
> IMHO the implementation done in MPLUGIN-425 and MPLUGIN-424 are wrong.
> They are way too aggresive and violate backward compatibility: if new feature 
> is not explicitly set by user, code should not "come up" with some automatic 
> value. By having the value not set simply means user does not want to use it.
> This is especially true for (maven or java) prerequisite, as it creates HARD 
> BREAKAGE if not met. Use of prerequisite is opt-in, but now it is FORCED onto 
> user.
> [~kwin] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to