[ 
https://issues.apache.org/jira/browse/MPLUGIN-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844184#comment-17844184
 ] 

Tamas Cservenak commented on MPLUGIN-522:
-----------------------------------------

For example the java prerequisite: why it gets "highest class version present 
on classpath"? Why not compiler target instead?

For Maven prerequisite: you cannot infer Maven prerequisite based on API you 
compile against. As mentioned, even if I compile against latest (3.9.6), the 
plugin may just fine work with 3.6.3 as well.

Hence, these two should be and remain (as before) opt in values. We cannot 
"deduce" what user wants, it is up to user to tell us what he wants.

> The auto prerequisites are way to aggressive
> --------------------------------------------
>
>                 Key: MPLUGIN-522
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-522
>             Project: Maven Plugin Tools
>          Issue Type: Bug
>          Components: Plugin Plugin
>            Reporter: Tamas Cservenak
>            Priority: Major
>
> IMHO the implementation done in MPLUGIN-425 and MPLUGIN-424 are wrong.
> They are way too aggresive and violate backward compatibility: if new feature 
> is not explicitly set by user, code should not "come up" with some automatic 
> value. By having the value not set simply means user does not want to use it.
> This is especially true for (maven or java) prerequisite, as it creates HARD 
> BREAKAGE if not met. Use of prerequisite is opt-in, but now it is FORCED onto 
> user.
> [~kwin] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to